refactor PMA_mult_submits and Add UT #603

Merged
merged 6 commits into from Aug 17, 2013

Projects

None yet

2 participants

@xmujay
Contributor
xmujay commented Aug 17, 2013

No description provided.

@xmujay
Contributor
xmujay commented Aug 17, 2013

Hi Marc,

the error is in this change : xmujay@8c9d122#L0L105

I have tested the following cases:
'add_prefix_tbl'
'replace_prefix_tbl'
'copy_tbl_change_prefix'
'drop_db'
'drop_tbl'
'empty_tbl'
'check_tbl'
'optimize_tbl'
'repair_tbl'
'analyze_tbl'
'export'
'drop_fld'
'change_fld'
'index_fld'

@xmujay
Contributor
xmujay commented Aug 17, 2013

more cases passed:
primary_fld
index_fld
unique_fld
change

row_change
row_export
row_delete

print
browse

@lem9 lem9 was assigned Aug 17, 2013
@lem9
Contributor
lem9 commented Aug 17, 2013

Nice work.

@lem9 lem9 merged commit 490b772 into phpmyadmin:master Aug 17, 2013

1 check passed

default The Travis CI build passed
Details
@lem9
Contributor
lem9 commented Aug 17, 2013

Hi Bin,
a further improvement is needed. The $what and $query_type variables seem to be used for the same purpose (but this needs verification). Maybe $what could become $query_type, can you verify this?

@xmujay
Contributor
xmujay commented Aug 17, 2013

Ok. I will verify the usage of $what and $query_type.

If possible, I will merge them after more investigation, thanks

@lem9
Contributor
lem9 commented Aug 25, 2013

Hi Bin,
any progress on this one?

@xmujay
Contributor
xmujay commented Aug 25, 2013

Hi Marc,
I am still doing this. I will send out the pull requests tomorrow about this.

I found that most jobs about refactoring server-view pages are finished. excepts these:

  1. server_priviledges need more refactors
  2. add more UT

I will finish the remaining work soon. If there are more urgent works that I can help on, just tell me, I will carry out to do them, thanks

@xmujay
Contributor
xmujay commented Sep 15, 2013

Hi Marc,

About this issue, I found that:
from the two branches:
branch 1 : about $what :
https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/mult_submits.inc.php#L123

branch 2: about $query_type:
https://github.com/phpmyadmin/phpmyadmin/blob/master/libraries/mult_submits.inc.php#L159

$what and $query_type are used in different branches with different logic.
If we merge them together, the two branches should be merged as well. so the logic will be more complicated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment