refactor server_databases: add function PMA_getListForSortDatabase #643

Merged
merged 1 commit into from Aug 26, 2013

Conversation

Projects
None yet
2 participants
@xmujay
Contributor

xmujay commented Aug 26, 2013

No description provided.

@ghost ghost assigned lem9 Aug 26, 2013

@xmujay

This comment has been minimized.

Show comment
Hide comment
@xmujay

xmujay Aug 26, 2013

Contributor

Hi Marc,
this pull request just to add function PMA_getListForSortDatabase to get sort data.

about the refactor of "Drops multiple databases", because of the multi-submit file in
https://github.com/xmujay/phpmyadmin/blob/eb368b2fd71741d3f2c0a8e8c9341b6dcc4eaeae/server_databases.php#L80

If I moved them to function, some variables should be added. I am still testing the refactor of "Drops multiple databases", thanks

Contributor

xmujay commented Aug 26, 2013

Hi Marc,
this pull request just to add function PMA_getListForSortDatabase to get sort data.

about the refactor of "Drops multiple databases", because of the multi-submit file in
https://github.com/xmujay/phpmyadmin/blob/eb368b2fd71741d3f2c0a8e8c9341b6dcc4eaeae/server_databases.php#L80

If I moved them to function, some variables should be added. I am still testing the refactor of "Drops multiple databases", thanks

@lem9

This comment has been minimized.

Show comment
Hide comment
@lem9

lem9 Aug 26, 2013

Contributor

Nice work. By the way, the sorting does not work (seems to be an old 4.0 problem) but it's not your bug so I'll merge this and will have a look at this bug later.

Contributor

lem9 commented Aug 26, 2013

Nice work. By the way, the sorting does not work (seems to be an old 4.0 problem) but it's not your bug so I'll merge this and will have a look at this bug later.

lem9 added a commit that referenced this pull request Aug 26, 2013

Merge pull request #643 from xmujay/refactor_database
refactor server_databases: add function PMA_getListForSortDatabase

@lem9 lem9 merged commit 7517dd5 into phpmyadmin:master Aug 26, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment