Refactor table print view #664

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@xmujay
Contributor

xmujay commented Sep 1, 2013

No description provided.

@xmujay

This comment has been minimized.

Show comment
Hide comment
@xmujay

xmujay Sep 1, 2013

Contributor

Hi Marc,

this pull request is to Refactor table print view.

I have tested following the steps:

  1. selected a database
  2. selected some tables on this database
  3. mult-submit ---> print view

I can see the print view pages. I found that the old code has a simple bug, some information print out by 'echo' is override by '$response->addHTML'

so I think you can see more page info when testing my code.

thanks

Contributor

xmujay commented Sep 1, 2013

Hi Marc,

this pull request is to Refactor table print view.

I have tested following the steps:

  1. selected a database
  2. selected some tables on this database
  3. mult-submit ---> print view

I can see the print view pages. I found that the old code has a simple bug, some information print out by 'echo' is override by '$response->addHTML'

so I think you can see more page info when testing my code.

thanks

/**
* Displays the footer
*/
-echo PMA_Util::getButton();

This comment has been minimized.

@xmujay

xmujay Sep 1, 2013

Contributor

in the old code, the echo out page elements will be overide by '$response->addHTML'

this issue has been fixed in this pull request

@xmujay

xmujay Sep 1, 2013

Contributor

in the old code, the echo out page elements will be overide by '$response->addHTML'

this issue has been fixed in this pull request

@ghost ghost assigned lem9 Sep 1, 2013

@lem9

This comment has been minimized.

Show comment
Hide comment
@lem9

lem9 Sep 2, 2013

Contributor

Hi Bin,
with the test you describe, we see the print view of the selected tables, however there are some problems: a weird "No change" message on top, also everything under the "Print" button should not be there.
I found that this scenario works well in QA_3_5, but is buggy in MAINT_4_0_5 and the current master. You version is an improvement but please fix these two issues.

Contributor

lem9 commented Sep 2, 2013

Hi Bin,
with the test you describe, we see the print view of the selected tables, however there are some problems: a weird "No change" message on top, also everything under the "Print" button should not be there.
I found that this scenario works well in QA_3_5, but is buggy in MAINT_4_0_5 and the current master. You version is an improvement but please fix these two issues.

@xmujay

This comment has been minimized.

Show comment
Hide comment
@xmujay

xmujay Sep 2, 2013

Contributor

thanks Marc,
I will fix these two issues ASAP, thanks

Contributor

xmujay commented Sep 2, 2013

thanks Marc,
I will fix these two issues ASAP, thanks

@xmujay

This comment has been minimized.

Show comment
Hide comment
@xmujay

xmujay Sep 2, 2013

Contributor

where is right place for the "Print" button? the bottom?

Contributor

xmujay commented Sep 2, 2013

where is right place for the "Print" button? the bottom?

@lem9

This comment has been minimized.

Show comment
Hide comment
@lem9

lem9 Sep 2, 2013

Contributor

Try to obtain the same output as QA_3_5 does.

Contributor

lem9 commented Sep 2, 2013

Try to obtain the same output as QA_3_5 does.

@lem9

This comment has been minimized.

Show comment
Hide comment
@lem9

lem9 Sep 3, 2013

Contributor

Closing for now.

Contributor

lem9 commented Sep 3, 2013

Closing for now.

@lem9 lem9 closed this Sep 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment