Bug Fix 4141 #752

Merged
merged 1 commit into from Nov 12, 2013

Conversation

Projects
None yet
2 participants
Contributor

scnakandala commented Nov 11, 2013

No description provided.

- if ($("#pageselector").length != 0) {
- $("#pageselector").trigger('change');
- } else {
- $("input[name=navig].ajax").trigger('click');
@scnakandala

scnakandala Nov 11, 2013

Contributor

This line was the line which was creating the problem of jumping between pages.

- if ($("#pageselector").length != 0) {
- $("#pageselector").trigger('change');
- } else {
- $("input[name=navig].ajax").trigger('click');
@scnakandala

scnakandala Nov 11, 2013

Contributor

This one also !

Contributor

scnakandala commented Nov 11, 2013

Hi Marc,
I think I found where things go wrong. According to my understanding without these code segments the code works fine. So I removed them. What is your opinion ?

@ghost ghost assigned lem9 Nov 11, 2013

Contributor

lem9 commented Nov 12, 2013

Hi Supun,
I am verifying the goal of these code segments.

Contributor

lem9 commented Nov 12, 2013

Hi Supun,
I could not find the goal of these code segments (this is surprising) so I'll merge your pull request. Can you work on the second part of bug #4141 (stop showing the multi-insert dialog in a modal window) ?

lem9 added a commit that referenced this pull request Nov 12, 2013

@lem9 lem9 merged commit dfda271 into phpmyadmin:QA_4_0 Nov 12, 2013

1 check passed

default The Travis CI build passed
Details
Contributor

scnakandala commented Nov 12, 2013

Hi Marc,
I'll work on it.

On Tue, Nov 12, 2013 at 5:26 PM, Marc Delisle notifications@github.comwrote:

Merged #752 #752.


Reply to this email directly or view it on GitHubhttps://github.com/phpmyadmin/phpmyadmin/pull/752
.

Thank you
Supun Nakandala
Dept. Computer Science and Engineering
University of Moratuwa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment