When importing a CSV file force a trailing new line at EOF (bug #4133) #763

Merged
merged 1 commit into from Nov 21, 2013

Conversation

Projects
None yet
3 participants
Contributor

slimtim commented Nov 20, 2013

Fix for bug #4133.
https://sourceforge.net/p/phpmyadmin/bugs/4133/

When importing a CSV file this new code adds a trailing new line at end-of-file if one does not exist. Otherwise you can run into a condition where the last line of the file is skipped by the parser or an error occurs stating, "Invalid format of CSV input on line XX"

Coverage Status

Coverage decreased (-0.01%) when pulling 2e7c024 on slimtim:bug_4133 into 7a6c258 on phpmyadmin:master.

lem9 was assigned Nov 21, 2013

Contributor

lem9 commented Nov 21, 2013

Thanks for your contribution.

@lem9 lem9 added a commit that referenced this pull request Nov 21, 2013

@lem9 lem9 Merge pull request #763 from slimtim/bug_4133
When importing a CSV file force a trailing new line at EOF (bug #4133)
240d37e

@lem9 lem9 merged commit 240d37e into phpmyadmin:master Nov 21, 2013

1 check passed

default The Travis CI build passed
Details

@whitepiegon whitepiegon added a commit to whitepiegon/phpmyadmin that referenced this pull request Mar 30, 2015

@whitepiegon whitepiegon #763 jquery validation feature
Signed-off-by: Aayush Anand <aayushism12@gmail.com>
16fb7d9

@whitepiegon whitepiegon added a commit to whitepiegon/phpmyadmin that referenced this pull request Mar 30, 2015

@whitepiegon whitepiegon #763 jquery validation feature2
Signed-off-by: Aayush Anand <aayushism12@gmail.com>
ec40c5c

@whitepiegon whitepiegon added a commit to whitepiegon/phpmyadmin that referenced this pull request Mar 31, 2015

@whitepiegon whitepiegon #763 jquery validation feature3
Signed-off-by: Aayush Anand <aayushism12@gmail.com>
080edb0

@lem9 lem9 added a commit that referenced this pull request Apr 5, 2015

@lem9 lem9 Merge pull request #1622 from whitepiegon/masterFeature2
#763 jquery validation feature
708736a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment