fixed #4204 Reloading user privileges hides user groups submenu #856

Closed
wants to merge 2 commits into
from

3 participants

@vpowerrc

Signed-off-by: Viduranga Wijesooriya vpowerrc@gmail.com

@vpowerrc vpowerrc fixed #4204 Reloading user privileges hides user groups submenu
Signed-off-by: Viduranga Wijesooriya <vpowerrc@gmail.com>
459d0ed
@coveralls

Coverage Status

Coverage decreased (-0.01%) when pulling 459d0ed on vpowerrc:QA_4_1 into d36b3ac on phpmyadmin:QA_4_1.

@vpowerrc vpowerrc fixed #4229 Javascript error in SQL edit window
Signed-off-by: Viduranga Wijesooriya <vpowerrc@gmail.com>
2e72c07
@lem9 lem9 was assigned Jan 14, 2014
@lem9

Viduranga,
do you have something else to work on for this fix, before I test it?

@vpowerrc
@coveralls

Coverage Status

Coverage decreased (-0.01%) when pulling 2e72c07 on vpowerrc:QA_4_1 into d36b3ac on phpmyadmin:QA_4_1.

@lem9

Viduranga,
next time, please use one branch per fix, because using your QA_4_1 branch, all its changes go into one pull request.

@lem9

I'm not sure about this patch. With this, the two buttons appear on every page, for example with "Add user". In this case I would have a "Users overview" button which seems active, and the page does not show the overview at all.

@vpowerrc vpowerrc closed this Jan 15, 2014
@vpowerrc

Shouldn't that submenu be shown in add user page ? User can quickly navigate, know ? For example; currently 'Add user group' page have that same submenu.
I also made a fix without them. Please check #858
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment