fixed bug #4257 Hide fractional seconds #882

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
@vidurangaw
Contributor

vidurangaw commented Jan 29, 2014

Signed-off-by: Viduranga Wijesooriya vpowerrc@gmail.com

fixed bug #4257 Hide fractional seconds
Signed-off-by: Viduranga Wijesooriya <vpowerrc@gmail.com>
@coveralls

This comment has been minimized.

Show comment Hide comment
@coveralls

coveralls Jan 29, 2014

Coverage Status

Coverage decreased (-0.01%) when pulling e300b43 on vpowerrc:bug#4257 into 2baa137 on phpmyadmin:QA_4_1.

Coverage Status

Coverage decreased (-0.01%) when pulling e300b43 on vpowerrc:bug#4257 into 2baa137 on phpmyadmin:QA_4_1.

@lem9

This comment has been minimized.

Show comment Hide comment
@lem9

lem9 Jan 29, 2014

Contributor

A complete solution for this problem should address also the popup that appears when grid editing the column or when editing a row. Also, I suspect that a verification for the MySQL version should be done,

Contributor

lem9 commented Jan 29, 2014

A complete solution for this problem should address also the popup that appears when grid editing the column or when editing a row. Also, I suspect that a verification for the MySQL version should be done,

@lem9 lem9 closed this Jan 29, 2014

@vidurangaw

This comment has been minimized.

Show comment Hide comment
@vidurangaw

vidurangaw Jan 29, 2014

Contributor

Yes I only saw that now. I only checked this with 'time' type. popup box appears with datetime and timestamp. So have to fix them too. We need to check mysql version for that. I will try to fix it too

Contributor

vidurangaw commented Jan 29, 2014

Yes I only saw that now. I only checked this with 'time' type. popup box appears with datetime and timestamp. So have to fix them too. We need to check mysql version for that. I will try to fix it too

@JorisDebonnet

This comment has been minimized.

Show comment Hide comment
@JorisDebonnet

JorisDebonnet Jan 29, 2014

I don't understand why the MySQL version needs to be checked. This issue completely and only depends on the definition of the table field: if it has a positive number (such as TIME(6), TIMESTAMP(6), DATETIME(6)), then the microseconds should be shown. If there is no number (or it is 0), they should not be shown. That's all there is to it! :)

MySQL versions that do not support it will not have a number. For MySQL versions that do support it, but where you see 0, there should still be no microsecond mentions anywhere in the interface. So the MySQL version does not (directly) make any difference, it's all in the field definition.

Further: to be really awesome, if possible, it should actually display only N digits since you can also define TIME(3) etc. That's mostly for the tabular displaying; not so much the popup, I'm sure all-or-nothing is fine there.

I don't understand why the MySQL version needs to be checked. This issue completely and only depends on the definition of the table field: if it has a positive number (such as TIME(6), TIMESTAMP(6), DATETIME(6)), then the microseconds should be shown. If there is no number (or it is 0), they should not be shown. That's all there is to it! :)

MySQL versions that do not support it will not have a number. For MySQL versions that do support it, but where you see 0, there should still be no microsecond mentions anywhere in the interface. So the MySQL version does not (directly) make any difference, it's all in the field definition.

Further: to be really awesome, if possible, it should actually display only N digits since you can also define TIME(3) etc. That's mostly for the tabular displaying; not so much the popup, I'm sure all-or-nothing is fine there.

@lem9

This comment has been minimized.

Show comment Hide comment
@lem9

lem9 Jan 29, 2014

Contributor

Thanks Joris; I had mentioned the MySQL version only because it's easier to do, but you are right, we have to verify the column's definition.

Contributor

lem9 commented Jan 29, 2014

Thanks Joris; I had mentioned the MySQL version only because it's easier to do, but you are right, we have to verify the column's definition.

@vidurangaw

This comment has been minimized.

Show comment Hide comment
@vidurangaw

vidurangaw Jan 29, 2014

Contributor

I already changed it to use mysql version to decide whether to show fractions. But now I also understand that column's definition is the only thing that matters, not mysql version. I will get on it right away

Contributor

vidurangaw commented Jan 29, 2014

I already changed it to use mysql version to decide whether to show fractions. But now I also understand that column's definition is the only thing that matters, not mysql version. I will get on it right away

@vidurangaw vidurangaw deleted the vidurangaw:bug#4257 branch Jan 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment