Fix For Wildcard-containing only_db failure in sidebar #898

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@Vasu014
Contributor
Vasu014 commented Feb 7, 2014

This commit fixes the Bug #4242. The only_db now accepts mySQL
LIKE wildcards without errors.Changes have been made to the function
getData() in phpmyadmin/libraries/navigation/Nodes/Node.class.php .
The if-else clause has been removed. The checking of the "only_db"
directive is now performed solely by the function
getWhereClause()in the same class.

@Vasu014 Vasu014 Fix For Wildcard-containing only_db failure in sidebar
This commit fixes the Bug #4242. The only_db now accepts mySQL
LIKE wildcards without errors.Changes have been made to the function
getData() in phpmyadmin/libraries/navigation/Nodes/Node.class.php .
The if-else clause has been removed. The checking of the "only_db"
directive is now performed solely by the function
getWhereClause()in the same class.
9f3e794
@coveralls

Coverage Status

Coverage remained the same when pulling 9f3e794 on Vasu014:MAINT_4_1_5 into 01aed71 on phpmyadmin:MAINT_4_1_5.

@lem9 lem9 self-assigned this Feb 8, 2014
@lem9
Contributor
lem9 commented Feb 8, 2014

Thanks, your fix looks good. Now, to be accepted in the code base:

  • start from QA_4_1 branch, create a bugfix branch (for example bug4242) and target our QA_4_1 for your pull request
  • read our DCO file and if you agree with it and our license, redo your commit but this time sign it (git -s)
@lem9 lem9 closed this Feb 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment