PMA_CommonFunctions class was used singleton pattern which is not exact place to use. Instead class is make as a static class. Class has renamed as PMA_Util.
Make all functions static
Change the way of method calling in same class from ->method() to sel…
Remove the unnecessary parts and renamed the class to PMA_Util
Renamed the file to Util.class.php and modify the relavant files
Renamed ->method() with PMA_Util::method()
Renamed PMA_CommonFunctions::getInstance()-> with PMA_Util::
Modified some untracked changes
Modify classes with property
Modified some untracked files
Merge remote branch 'upstream/master'
newline is not necessary (there are some more in this commit; check below)
Generally looks good, but I'm not sure if it's good time to merge now because of @roccivic GSoC project is still unmerged... Either way merging or not merging this will cause conflicts in the end for the one which will be merged later.
I'm in favour of merging now, as it will take some time before @roccivic's branch is ready to merge. If we wait too long, this pull request can't be automatically merged because too much changes were done to master in the mean time (as is the case now) and it will only get worse.
@Chanaka, can you merge master with this branch, resolve the issues and push the changes? Then we can merge it with master.
@roccivic will have to merge master in his branch and update the calls to PMA_CommonFunctions in the code that is specific for his branch.
I'm okay with merging, just wanted to check @roccivic's status.
Removed unnecessary empty lines in functions
If everyone wants to merge, then go ahead.