New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PSR-1 for PHPUnit TestCase #20

Merged
merged 1 commit into from Nov 8, 2017

Conversation

Projects
None yet
2 participants
@carusogabriel
Contributor

carusogabriel commented Nov 6, 2017

Use PSR-1 while extending PHPUnit TestCase class. This will help us when to migrate to PHPUnit 6, that no longer support snake case namespaces.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 6, 2017

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #20   +/-   ##
=========================================
  Coverage     92.96%   92.96%           
  Complexity      277      277           
=========================================
  Files             3        3           
  Lines           824      824           
=========================================
  Hits            766      766           
  Misses           58       58

codecov bot commented Nov 6, 2017

Codecov Report

Merging #20 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #20   +/-   ##
=========================================
  Coverage     92.96%   92.96%           
  Complexity      277      277           
=========================================
  Files             3        3           
  Lines           824      824           
=========================================
  Hits            766      766           
  Misses           58       58

@nijel nijel merged commit 404f5f0 into phpmyadmin:master Nov 8, 2017

5 checks passed

Scrutinizer No new issues
Details
codacy/pr Good work! A positive pull request.
Details
codecov/patch Coverage not affected when comparing 807a8a9...a47fe1d
Details
codecov/project 92.96% remains the same compared to 807a8a9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nijel nijel self-assigned this Nov 8, 2017

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Nov 8, 2017

Member

Merged, thanks for your contribution!

Member

nijel commented Nov 8, 2017

Merged, thanks for your contribution!

@carusogabriel carusogabriel deleted the carusogabriel:phpunit branch Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment