New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #172 Support parameter binding #173

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
2 participants
@madhuracj
Member

madhuracj commented Sep 12, 2017

No description provided.

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Sep 15, 2017

Member

Looking at testsuite failures, this breaks handling of assignment operator:=.

Member

nijel commented Sep 15, 2017

Looking at testsuite failures, this breaks handling of assignment operator:=.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 23, 2017

Codecov Report

Merging #173 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #173      +/-   ##
============================================
+ Coverage     99.61%   99.61%   +<.01%     
- Complexity     1737     1744       +7     
============================================
  Files            57       57              
  Lines          4701     4713      +12     
============================================
+ Hits           4683     4695      +12     
  Misses           18       18

codecov bot commented Sep 23, 2017

Codecov Report

Merging #173 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master     #173      +/-   ##
============================================
+ Coverage     99.61%   99.61%   +<.01%     
- Complexity     1737     1744       +7     
============================================
  Files            57       57              
  Lines          4701     4713      +12     
============================================
+ Hits           4683     4695      +12     
  Misses           18       18
Fix #172 Support parameter binding
Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
@madhuracj

This comment has been minimized.

Show comment
Hide comment
@madhuracj

madhuracj Sep 23, 2017

Member

@nijel Thanks for pointing that out. I think all is well now.

Member

madhuracj commented Sep 23, 2017

@nijel Thanks for pointing that out. I think all is well now.

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Sep 28, 2017

Member

Thanks, indeed looks good now.

Member

nijel commented Sep 28, 2017

Thanks, indeed looks good now.

@nijel nijel merged commit 8e50a4b into phpmyadmin:master Sep 28, 2017

4 checks passed

codacy/pr Good work! A positive pull request.
Details
codecov/patch 100% of diff hit (target 99.61%)
Details
codecov/project 99.61% (+<.01%) compared to 5ea32b4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nijel nijel self-assigned this Sep 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment