New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring tests #183

Merged
merged 1 commit into from Dec 15, 2017

Conversation

Projects
None yet
2 participants
@carusogabriel
Contributor

carusogabriel commented Dec 15, 2017

I've refactored some tests, using:

  • assertCount instead of count function;
  • assertArrayHasKey and assertArrayHasKey instead of isset function;
  • assertNull instead of comparison with null keyword.
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 15, 2017

Codecov Report

Merging #183 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #183   +/-   ##
=========================================
  Coverage     99.75%   99.75%           
  Complexity     1751     1751           
=========================================
  Files            57       57           
  Lines          4126     4126           
=========================================
  Hits           4116     4116           
  Misses           10       10

codecov bot commented Dec 15, 2017

Codecov Report

Merging #183 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #183   +/-   ##
=========================================
  Coverage     99.75%   99.75%           
  Complexity     1751     1751           
=========================================
  Files            57       57           
  Lines          4126     4126           
=========================================
  Hits           4116     4116           
  Misses           10       10

@nijel nijel merged commit 0f8d79b into phpmyadmin:master Dec 15, 2017

4 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
codecov/patch Coverage not affected when comparing acd10db...768a0d7
Details
codecov/project 99.75% remains the same compared to acd10db
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Dec 15, 2017

Member

Merged, thanks for your contribution!

Member

nijel commented Dec 15, 2017

Merged, thanks for your contribution!

@nijel nijel self-assigned this Dec 15, 2017

@carusogabriel carusogabriel deleted the carusogabriel:refactoring-tests branch Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment