psetex method returns '+OK' on success, not true

[ndxbn]

$redis = new Redis();
$redis->conenct();
$redis->psetex('a', 1, 1000); // returns "+OK", not true

In setter methods (ex. set(), setex()...) will returns true, but only psetex method will returns '+OK' string on success.
I think this is bug.

The bug may due to this line .
It should be "redis_boolean_response".

[yatsukhnenko]

@Sitri, nice catch! Could you create a pull request?

[ndxbn]

@yatsukhnenko yes, I'm working now.
Which branch should I work for PR? Is development ?

[yatsukhnenko]

@Sitri, yep, you can use develop brunch. Also, could you add test for this? Just copy/paste it from testSetEx? :)

[ndxbn]

@yatsukhnenko ok, thx.
I added this test (almost as testSetEx)

    public function testPSetEx() {
        $this->redis->del('key');
        $this->assertTrue($this->redis->psetex('key', 7 * 1000, 'val') === TRUE);
        $this->assertTrue($this->redis->ttl('key') ===7);
        $this->assertTrue($this->redis->get('key') === 'val');
    }

or is this not enaugh?

[yatsukhnenko]

👍

[ndxbn]

I created #944, please review to this