fixed bug different type command returns #229

Merged
merged 1 commit into from Feb 17, 2013

Conversation

Projects
None yet
3 participants
Contributor

rnamiki commented Aug 15, 2012

bug detail
i.g.

$ret = $redis->multi()
             ->set("stringkey", "val")
             ->lRange("stringkey", 0, 0)
             ->exec();
var_dump($ret);

expect:

array(2) {
  [0]=>
  bool(true)
  [1]=>
  bool(false)
}

actual:

array(1) {
  [0]=>
  bool(true)
}

Damn, that's one massive unit test!

Thanks for the pull request. I can replicate this issue and I'll check out your fix!

Cheers,
Mike

Contributor

nicolasff commented Feb 17, 2013

The test looks good and the fix seems fine too. I'll merge this in a hotfix branch.

@nicolasff nicolasff merged commit a65b609 into phpredis:master Feb 17, 2013

Contributor

nicolasff commented Feb 17, 2013

Pushed. Thanks a lot, @rnamiki!

Contributor

rnamiki commented Feb 18, 2013

many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment