Skip to content

Obtain a read only session if session lock fails - #2386

Open
exussum12 wants to merge 1 commit into
phpredis:developfrom
exussum12:patch-1
Open

exussum12 wants to merge 1 commit into
phpredis:developfrom
exussum12:patch-1

Conversation

@exussum12

@exussum12 exussum12 commented Sep 15, 2023 •

Copy link
Copy Markdown

If a session lock fails to obtain, use a read only version of the session. This causes less backwards compatible issues and was introduced between the 5.3.7 and 6.0.0 releases.

New note added to suggest the session is read only

Fixes #2382

Introduced here
687a0b4#diff-d7896829bc47f45d33720c352a4b8aabd4dca447b6db9e2d4205be5b44ba5d9eR714

If a session lock fails to obtain, use a read only version of the session.
This causes less backwards compatible issues and was introduced between the 5.3.7 and 6.0.0 releases.

New note added to suggest the session is read only

Fixes phpredis#2382
@exussum12

Copy link
Copy Markdown
Author

Any update on this?

@yatsukhnenko

Copy link
Copy Markdown
Member

I'm not sure that this is a good idea to ignore error when lock is not acquired

@arokettu

Copy link
Copy Markdown
Contributor

This should be closed because the change was merged in #2665

@exussum12

Copy link
Copy Markdown
Author

Should only be merged once the tag is released IMO

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redis 6.0 issues with session locking

4 participants