Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add php nightly tests #1242

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
2 participants
@andreybolonin
Copy link
Contributor

andreybolonin commented Jan 17, 2018

No description provided.

@terrafrost

This comment has been minimized.

Copy link
Member

terrafrost commented Jan 19, 2018

Something I'm curious about...

In phpseclib/mcrypt_compat@33b727d nightly tests were added but failures were allowed in them. In this one you add nightly tests but aren't allowing failures.

Do you have any thoughts on that approach vs this approach?

@terrafrost terrafrost merged commit ef0c0ee into phpseclib:master Feb 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.