Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove error suppression from stream_select() #1444
So it looks like error suppression (which has been in place since the timeout code was added on Jun 23, 2012) actually preceded the
That said, I'm not able to reproduce either issue on Windows. I tested it as low as PHP 5.0.5. It looks like a lot of people had issues reproducing the bug even in the bug report. As such I'm not even sure unit tests against https://www.appveyor.com/ would have helped.
Anyway, can you resubmit this PR but target the 3.0 branch instead? They're pretty much identical so it shouldn't be a ton of effort on your part (whereas on my part I'd have to add you as a remote then I'd have to cherry-pick your commit into the 3.0 branch).