SFTP: missing status code notice fix #91

Merged
merged 1 commit into from Apr 23, 2013

Conversation

Projects
None yet
2 participants
Contributor

mdesign83 commented Apr 23, 2013

My phpseclib thrown a few status code notices, so i created the missing ones.

@terrafrost terrafrost pushed a commit that referenced this pull request Apr 23, 2013

terrafrost Merge pull request #91 from mdesign83/master
SFTP: missing status code notice fix
141da70

@terrafrost terrafrost merged commit 141da70 into phpseclib:master Apr 23, 2013

1 check passed

default The Travis build passed
Details
Owner

terrafrost commented Apr 23, 2013

Out of curiosity what SFTP version are you running? The status codes phpseclib currently defines are defined the last v3 RFC: http://tools.ietf.org/html/draft-ietf-secsh-filexfer-02#page-21

Some of the ones added with this commit weren't even added the last draft on SFTPv6 http://tools.ietf.org/html/draft-ietf-secsh-filexfer-13#page-49 (not even the next to last draft defined SSH_FX_NO_MATCHING_BYTE_RANGE_LOCK, for instance).

Anyway, the commit looks good (hence my merging it lol) - I'm just curious if SFTPv3 servers are serving up SFTPv6 status codes lol.

Contributor

mdesign83 commented Apr 24, 2013

I needed only status 11 and 24, but i created the full list for sure.
I created the list about this page: http://tools.ietf.org/html/draft-ietf-secsh-filexfer-13#section-9.1

Our partner's sftp server info:
Protocol info:
Session protocol = SSH-2
SSH implementation = xlightftpd_release_3.7.5
Encryption algorithm = aes
Compression = No
File transfer protocol = SFTP-5

Capabilities:
Can change permissions = Yes
Can change owner/group = No
Can execute arbitrary command = No
Can create symlink/hardlink = Yes/No
Can lookup user groups = No
Can duplicate remote files = No
Can check available space = No
Can calculate file checksum = No
Native text (ASCII) mode transfers = Yes

Owner

terrafrost commented Apr 24, 2013

Hmmm - I've never seen an SFTPv5 server before. I've only tested phpseclib on SFTPv2/3. I'm gonna have to contact the xlightftpd people and see if they could provide me with a free copy of their app!

Owner

terrafrost commented Apr 25, 2013

The xlightftpd people gave me a copy! I'll prob test / flesh out SFTPv5 support next week - need to finish up SCP support up for someone else this week.

Thanks!!

Owner

terrafrost commented May 5, 2013

So I was playing around with xlightftpd and... it looks like it does SFTP-3 by default. How can you change it to SFTP-5?

Contributor

mdesign83 commented May 6, 2013

Sorry but i can't help. I use phpseclib with our partner's ftp server, and i don't know the setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment