Skip to content

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Oct 28, 2025

@ondrejmirtes
Copy link
Member

I'd like a PHPUnitVersion class that works the same way PhpVersion works in PHPStan. Methods asking about specific features.

@staabm
Copy link
Contributor Author

staabm commented Oct 28, 2025

here you are

@ondrejmirtes
Copy link
Member

The majorVersion is nullable when we can't detect it? I wonder if we should make the user of PHPUnitVersion explicitly handle it, because otherwise we're basically lying. When we can't detect it, the thing might be supported.

@staabm
Copy link
Contributor Author

staabm commented Oct 28, 2025

Ok. Adding trinary then

@staabm
Copy link
Contributor Author

staabm commented Oct 28, 2025

I just had my first mutation testing experience on a phpstan/* repo :)

@ondrejmirtes ondrejmirtes merged commit 758d343 into phpstan:2.0.x Oct 29, 2025
70 checks passed
@ondrejmirtes
Copy link
Member

Perfect, thank you!

@staabm staabm deleted the refac branch October 29, 2025 06:41
@ondrejmirtes
Copy link
Member

I just had my first mutation testing experience on a phpstan/* repo 😊

Let's record this here: https://github.com/phpstan/phpstan-phpunit/actions/runs/18886595907/job/53903464005

The log will disappear after some time so here's a screenshot:

Screenshot 2025-10-29 at 9 53 02

This is what I had in mind the whole time, I'm glad it pays off 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants