-
Notifications
You must be signed in to change notification settings - Fork 50
Refactor PHPUnitVersionDetector to ease different major version checks #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'd like a PHPUnitVersion class that works the same way PhpVersion works in PHPStan. Methods asking about specific features. |
|
here you are |
|
The majorVersion is nullable when we can't detect it? I wonder if we should make the user of PHPUnitVersion explicitly handle it, because otherwise we're basically lying. When we can't detect it, the thing might be supported. |
|
Ok. Adding trinary then |
|
I just had my first mutation testing experience on a phpstan/* repo :) |
|
Perfect, thank you! |
Let's record this here: https://github.com/phpstan/phpstan-phpunit/actions/runs/18886595907/job/53903464005 The log will disappear after some time so here's a screenshot:
This is what I had in mind the whole time, I'm glad it pays off 👏 |

required for phpstan/phpstan-src#4490 (comment)