Prevent unnecesary calls to isSuperTypeOf

phpstan · Jun 18, 2024 · 7a07852 · 7a07852
1 parent ab74e58
commit 7a07852
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/src/Reflection/InitializerExprTypeResolver.php b/src/Reflection/InitializerExprTypeResolver.php
@@ -1350,9 +1350,7 @@ public function resolveIdenticalType(Type $leftType, Type $rightType): BooleanTy
 			return new ConstantBooleanType($leftTypeFiniteTypes[0]->equals($rightTypeFiniteType[0]));
 		}
 
-		$isLeftSupertype = $leftType->isSuperTypeOf($rightType);
-		$isRightSupertype = $rightType->isSuperTypeOf($leftType);
-		if ($isLeftSupertype->no() && $isRightSupertype->no()) {
+		if ($leftType->isSuperTypeOf($rightType)->no() && $rightType->isSuperTypeOf($leftType)->no()) {
 			return new ConstantBooleanType(false);
 		}