CallToStaticMethodStamentWithoutSideEffectsRule - skip parent::__cons…

…truct()
phpstan · Nov 1, 2020 · c8e4f8b · c8e4f8b · dktapps · Nov 2, 2020
1 parent 3714a73
commit c8e4f8b
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/Rules/Methods/CallToStaticMethodStamentWithoutSideEffectsRule.php b/src/Rules/Methods/CallToStaticMethodStamentWithoutSideEffectsRule.php
@@ -79,6 +79,15 @@ static function (Type $type) use ($methodName): bool {
 		}
 
 		$method = $calledOnType->getMethod($methodName, $scope);
+		if (
+			(
+				strtolower($method->getName()) === '__construct'
+				|| strtolower($method->getName()) === strtolower($method->getDeclaringClass()->getName())
+			)
+		) {
+			return [];
+		}
+
 		if ($method->hasSideEffects()->no()) {
 			return [
 				RuleErrorBuilder::message(sprintf(

diff --git a/tests/PHPStan/Rules/Methods/data/static-method-call-statement-no-side-effects.php b/tests/PHPStan/Rules/Methods/data/static-method-call-statement-no-side-effects.php
@@ -25,3 +25,13 @@ public function doFoo()
 	}
 
 }
+
+class FooException extends \Exception
+{
+
+	public function __construct()
+	{
+		parent::__construct();
+	}
+
+}