Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnupg::geterror (etc) can return false #1735

Merged
merged 2 commits into from Sep 21, 2022
Merged

Conversation

Firehed
Copy link
Contributor

@Firehed Firehed commented Sep 20, 2022

The signature in the documentation code for several methods indicate what was in the file, but the Return Values (correctly) indicates that those same functions and methods can do the "return false on failure" thing (except one of them, which instead returns null on failure 馃う )

Firehed added 2 commits Sep 20, 2022
The signature in the documentation _code_ says it returns string, but the Return Values (correctly) indicates that it returns string or false on failure.
There were several other signature mismatches, including a couple missing functions.
@Firehed Firehed changed the title gnupg::geterror can return false gnupg::geterror (etc) can return false Sep 21, 2022
@ondrejmirtes ondrejmirtes merged commit 8b99661 into phpstan:1.8.x Sep 21, 2022
221 of 224 checks passed
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Sep 21, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants