Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array_unshift for union of constant arrays #1738

merged 1 commit into from Sep 22, 2022


Copy link

No description provided.

@rvanvelzen rvanvelzen changed the title Fix array_unshift for union of constant arrays Fix array_unshift for union of constant arrays Sep 22, 2022
Copy link

herndlm commented Sep 22, 2022

Thank you! I wrongfully implemented this before I fully understood how the constant array type helpers work :)

What do you think of moving your new tests to and also adding the analogue thing for which should be fixed/improved too?

@ondrejmirtes ondrejmirtes merged commit 9077af6 into phpstan:1.8.x Sep 22, 2022
Copy link

Thank you!

@rvanvelzen rvanvelzen deleted the constant-array-union-unshift branch September 22, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
3 participants