Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix array_unshift for union of constant arrays #1738

Merged
merged 1 commit into from Sep 22, 2022

Conversation

rvanvelzen
Copy link
Contributor

@rvanvelzen rvanvelzen commented Sep 22, 2022

No description provided.

@rvanvelzen rvanvelzen changed the title Fix array_unshift for union of constant arrays Fix array_unshift for union of constant arrays Sep 22, 2022
@herndlm
Copy link
Contributor

herndlm commented Sep 22, 2022

Thank you! I wrongfully implemented this before I fully understood how the constant array type helpers work :)

What do you think of moving your new tests to https://github.com/phpstan/phpstan-src/blob/1.8.5/tests/PHPStan/Analyser/data/array-unshift.php and also adding the analogue thing for https://github.com/phpstan/phpstan-src/blob/1.8.5/tests/PHPStan/Analyser/data/array-push.php which should be fixed/improved too?

@ondrejmirtes ondrejmirtes merged commit 9077af6 into phpstan:1.8.x Sep 22, 2022
222 of 225 checks passed
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Sep 22, 2022

Thank you!

@rvanvelzen rvanvelzen deleted the constant-array-union-unshift branch Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants