Skip to content

fix IntlDateFormatter::create return signature#1776

Merged
ondrejmirtes merged 1 commit intophpstan:1.8.xfrom
Kleinast:fix-IntlDateFormatter-create
Oct 12, 2022
Merged

fix IntlDateFormatter::create return signature#1776
ondrejmirtes merged 1 commit intophpstan:1.8.xfrom
Kleinast:fix-IntlDateFormatter-create

Conversation

@Kleinast
Copy link

Conf php doc => https://www.php.net/manual/en/intldateformatter.create.php

I didn't manage to install and run test for this phpstan-src project.
When I do:

composer install
make tests

I get

php vendor/bin/paratest --runner WrapperRunner --no-coverage
You need to set up the project dependencies using the following commands:
curl -s http://getcomposer.org/installer | php
php composer.phar install

autoload.php is not created
and if I do:
composer update
it endup with

- Applying patches for jetbrains/phpstorm-stubs (2)
    ~ phpstan/phpstan-src: patches/PDO.patch [NEW]
      Failed to apply the patch. Halting execution!

Did I miss something to make it work ?

Thx for your time

@ondrejmirtes ondrejmirtes force-pushed the fix-IntlDateFormatter-create branch from 76ac8b0 to f10c507 Compare October 5, 2022 15:40
@ondrejmirtes ondrejmirtes merged commit 7a6ff57 into phpstan:1.8.x Oct 12, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@ondrejmirtes
Copy link
Member

About your issues - I don't know, it's pretty much standard, it works on my machine and in CI. What error did you get with composer install?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants