Fix SoapFault constructor type#1798
Merged
ondrejmirtes merged 2 commits intophpstan:1.8.xfrom Oct 12, 2022
Merged
Conversation
Member
|
Could you please add a test to make sure it's fixed? Because there are multiple sources of these headers, it's not obvious this is actually gonna fix that. (PhpStorm stubs are also wrong in PHPDocs, would be nice to send a PR there too.) |
Member
|
Oh, you did already :) |
Contributor
Author
|
I had to split the exceptions so everyone has its own function scope. because the test was reporting only the first |
ahmedash95
force-pushed
the
fix-soapfault
branch
from
016a661 to
ad58fa8
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file is updated manually as I couldn't find if there is a generator or not.
Addresses phpstan/phpstan#8111