Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option usePathConstantsAsConstantString #2050

merged 1 commit into from Dec 16, 2022


Copy link

No description provided.

Copy link

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new ConstantStringType($file) part is repeated here. I'd like the code to change so that the last line call looks like this:

return $this->usePathConstantsAsConstantString ? $stringType : $stringType->generalize(GeneralizePrecision::moreSpecific());

@ondrejmirtes ondrejmirtes merged commit 0f1ba7f into phpstan:1.9.x Dec 16, 2022
192 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants