Fix native type on unset #2107
Merged
Fix native type on unset #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
|
Thank you, don't worry about it |
|
Regression test please |
staabm
reviewed
Dec 14, 2022
Comment on lines
5
to
+6
| use function PHPStan\Testing\assertType; | ||
| use function PHPStan\Testing\assertNativeType; |
There was a problem hiding this comment.
@ondrejmirtes wdyt about adding a rule/check which verifies that tests included by TypeInferenceTestCase contain proper full-qualified method calls or imports when assertType or assertNativeType is contained?
There was a problem hiding this comment.
@staabm We can make TypeInferenceTestCase crash on the supported functions with correct names but without (or with a wrong) namespace :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Two fixes
I'm sorry that I didn't add enough tests when adding these native type changes...
proof of wrong native type on unset
https://phpstan.org/r/85d3f157-6989-4e60-90f3-9aa7a90546ee