Keep NeverType isExplicit-flag in InitializerExprTypeResolver #2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
staabm
commented
Dec 15, 2022
| { | ||
| $initializerExprTypeResolver = self::getContainer()->getByType(InitializerExprTypeResolver::class); | ||
|
|
||
| $result = $initializerExprTypeResolver->getPlusType( |
There was a problem hiding this comment.
I did only a single test as a representative for one operation.
should I test every single one?
There was a problem hiding this comment.
But you should test all the branches obviously, ideally with a dataProvider. So when the left type is explicit, when the right type is explicit, and when none of them are.
staabm
force-pushed
the
explicit-never
branch
3 times, most recently
from
9ab8618
to
332f6b4
Compare
staabm
force-pushed
the
explicit-never
branch
from
332f6b4
to
a306085
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
similar to #2112
before this PR we lost the explicit-flag on NeverType, when expressions were used in arithmentic operations.
with the changes the explicit flag is preserved.