Lazy initialization of AnalyserResult::$errors

[takaram]

AnalyserResult::$errors array is sorted in the class' constructor, but it doesn't always need to be sorted.
This PR makes the property be initialized when getErrors is called.

In AnalyseApplication::analyse we may get two AnalyserResult instances. One of them is just an intermediate result, so its error array doesn't have to be sorted.
Sorting an array with usort may take a few seconds if the array has thousands of elements.

[phpstan-bot]

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

[ondrejmirtes]

Can you please share a use case where AnalyserResult is created but errors aren't read? Thank you.

[mad-briller]

@ondrejmirtes i think this isn't in relation to them being created but not read, but more to avoid the cost of sorting twice

on line 80 of AnalyseApplication there is this:

$intermediateAnalyserResult = $this->runAnalyser(

which produces an AnalyserResult and as such has sorted the errors once,
but then later on on line 94 there is this:

$intermediateAnalyserResult = new AnalyserResult(
	array_merge($intermediateAnalyserResult->getErrors(), $stubErrors),

which will re-sort the errors, including any additional errors produced in stubs

this change makes it so that the errors are only sorted once

[ondrejmirtes]

@mad-briller Are you sure? There's $intermediateAnalyserResult->getErrors() call in the code you posted.

[mad-briller]

yeah, the getErrors call in the code i posted returns already-sorted errors, which will then be sorted again in the AnalyserResult constructor

[ondrejmirtes]

But after this PR they will get sorted twice anyway, right?

[mad-briller]

the pr actually changes the call to getError in the second instance to a getUnorderedErrors, the code samples i used were from before the change had happened to explain what it was targeting

			$intermediateAnalyserResult = new AnalyserResult(
					array_merge($intermediateAnalyserResult->getUnorderedErrors(), $stubErrors),
					```

[ondrejmirtes]

I get it now 😊

[ondrejmirtes]

Thank you.

[takaram]

@mad-briller
Thank you so much for answering the question! I didn't have enough time to answer😅