Impl StrIncrementDecrementFunctionReturnTypeExtension #2776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonuexe
changed the title
zonuexe
commented
Nov 25, 2023
| } | ||
| } | ||
|
|
||
| return (string)++$s; |
There was a problem hiding this comment.
zonuexe
force-pushed
the
feature/str_increment_decrement
branch
2 times, most recently
from
d228654 to
1bb4a34
Compare
ondrejmirtes
requested changes
Nov 26, 2023
resources/functionMap_php83delta.php
Outdated
| return [ | ||
| 'new' => [ | ||
| 'str_decrement' => ['non-empty-string'], | ||
| 'str_increment' => ['non-falsy-string'], |
There was a problem hiding this comment.
This signature is wrong. The functions also have parameters.
src/Type/Php/StrIncrementDecrementFunctionReturnTypeExtension.php
Outdated
Show resolved
Hide resolved
| { | ||
| if (function_exists('str_increment')) { | ||
| try { | ||
| return str_increment($s); |
There was a problem hiding this comment.
Or maybe we can always call our own implementation and not have a different one here.
zonuexe
force-pushed
the
feature/str_increment_decrement
branch
from
1bb4a34 to
77dbe4f
Compare
ondrejmirtes
requested changes
Nov 26, 2023
| $args = $functionCall->getArgs(); | ||
|
|
||
| if (count($args) !== 1) { | ||
| return ParametersAcceptorSelector::selectSingle($functionReflection->getVariants())->getReturnType(); |
There was a problem hiding this comment.
You can just return null in these cases
| return ParametersAcceptorSelector::selectSingle($functionReflection->getVariants())->getReturnType(); | ||
| } | ||
|
|
||
| $value = $argType->getConstantScalarValues()[0]; |
There was a problem hiding this comment.
You should account for union of values, don't just read the first one
There was a problem hiding this comment.
I see, I misunderstood UnionType::getConstantScalarValues().
zonuexe
force-pushed
the
feature/str_increment_decrement
branch
from
e5616f6 to
f903595
Compare
zonuexe
force-pushed
the
feature/str_increment_decrement
branch
from
f903595 to
a8eb826
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add types to
str_increment()andstr_decrement()added in PHP 8.3.However, unlike something like
strtolower(), I can't think of many use cases for incrementing/decrementing constants, so it makes sense to reject this PR.