get_debug_type() DynamicFunctionReturnTypeExtension bugfix #3128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickkusebauch
changed the title
patrickkusebauch
changed the title
|
Please add the failing example as a new test in AnalyserIntegrationTest (and make sure it fails first). Thanks. |
|
I will, I will, I wanted to get something going and iterate on it. Need to remind myself how to run testing locally again. It has been a while. |
|
Just vendor/bin/phpunit and path to the file with the test 😊 |
|
Thanks for the help and direction. |
This comment was marked as resolved.
This comment was marked as resolved.
… the list of class names and list of class reflections line up.
|
Thank you! |
Open
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: phpstan/phpstan#11147
Bug where I incorrectly assumed that the lists of class names and class reflections line up.