Skip to content

Solve identical comparison with local-variance #3153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

VincentLanglet
Copy link
Contributor

@VincentLanglet VincentLanglet commented Jun 12, 2024

@VincentLanglet VincentLanglet marked this pull request as draft June 12, 2024 13:41
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@staabm
Copy link
Contributor

staabm commented Jun 12, 2024

Issue-bot reported this seem to fix also another issue: https://github.com/phpstan/phpstan-src/actions/runs/9484392325

Please add a regression test

Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that regression test too please.

@VincentLanglet
Copy link
Contributor Author

Yeah, that regression test too please.

Done

@ondrejmirtes ondrejmirtes merged commit 01e5828 into phpstan:1.11.x Jun 17, 2024
446 of 449 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strict comparaison is considered as always false when using local-variance False-positive identical.alwaysFalse
4 participants