Add "base64" as key for stream_get_meta_data #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the right "data" url, PHP will add a boolean "base64" key to `stream_get_meta_data`. See some example code in action: https://3v4l.org/G65j4
|
Hi, the key should be marked as optional. |
|
I'd like to if I knew how to. I am using the same format as "mediatype", which has been added years ago when this file was at a different location, and it also isn't marked as optional. I found that arguments can be marked as optional using |
|
https://phpstan.org/writing-php-code/phpdoc-types#array-shapes See for example |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the right "data" url, PHP will add a boolean "base64" key to
stream_get_meta_data.See some example code in action: https://3v4l.org/G65j4