From 993079024b5a39278279c1c499f0ca04540b06aa Mon Sep 17 00:00:00 2001 From: sayuprc Date: Wed, 19 Mar 2025 21:50:30 +0900 Subject: [PATCH 1/4] Fix always-true detection in in_array with union type haystack --- src/Rules/Comparison/ImpossibleCheckTypeHelper.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/Rules/Comparison/ImpossibleCheckTypeHelper.php b/src/Rules/Comparison/ImpossibleCheckTypeHelper.php index b0e71448b5..bfc1da4757 100644 --- a/src/Rules/Comparison/ImpossibleCheckTypeHelper.php +++ b/src/Rules/Comparison/ImpossibleCheckTypeHelper.php @@ -153,6 +153,10 @@ public function findSpecifiedType( foreach ($haystackArrayTypes as $haystackArrayType) { if ($haystackArrayType instanceof ConstantArrayType) { foreach ($haystackArrayType->getValueTypes() as $i => $haystackArrayValueType) { + if ($haystackArrayValueType instanceof UnionType) { + continue; + } + if ($haystackArrayType->isOptionalKey($i)) { continue; } From d57c50d9eb3d6898e39bfeea7d0af9d4349670f9 Mon Sep 17 00:00:00 2001 From: sayuprc Date: Thu, 20 Mar 2025 23:10:46 +0900 Subject: [PATCH 2/4] Simplify --- src/Rules/Comparison/ImpossibleCheckTypeHelper.php | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/Rules/Comparison/ImpossibleCheckTypeHelper.php b/src/Rules/Comparison/ImpossibleCheckTypeHelper.php index bfc1da4757..4e30d9c2fb 100644 --- a/src/Rules/Comparison/ImpossibleCheckTypeHelper.php +++ b/src/Rules/Comparison/ImpossibleCheckTypeHelper.php @@ -153,11 +153,7 @@ public function findSpecifiedType( foreach ($haystackArrayTypes as $haystackArrayType) { if ($haystackArrayType instanceof ConstantArrayType) { foreach ($haystackArrayType->getValueTypes() as $i => $haystackArrayValueType) { - if ($haystackArrayValueType instanceof UnionType) { - continue; - } - - if ($haystackArrayType->isOptionalKey($i)) { + if ($haystackArrayValueType instanceof UnionType || $haystackArrayType->isOptionalKey($i)) { continue; } From 26193be956f8c09e1edc65c235491591f43713b3 Mon Sep 17 00:00:00 2001 From: sayuprc Date: Fri, 21 Mar 2025 14:47:14 +0900 Subject: [PATCH 3/4] Add test cases --- ...mpossibleCheckTypeFunctionCallRuleTest.php | 10 +++- .../Rules/Comparison/data/bug-12755.php | 55 +++++++++++++++++++ 2 files changed, 64 insertions(+), 1 deletion(-) diff --git a/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php b/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php index f83bd6f26f..726954bb66 100644 --- a/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php +++ b/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php @@ -995,8 +995,16 @@ public function testBug8818(): void public function testBug12755(): void { + $tipText = 'Because the type is coming from a PHPDoc, you can turn off this check by setting treatPhpDocTypesAsCertain: false in your %configurationFile%.'; + $this->treatPhpDocTypesAsCertain = true; - $this->analyse([__DIR__ . '/data/bug-12755.php'], []); + $this->analyse([__DIR__ . '/data/bug-12755.php'], [ + [ + 'Call to function in_array() with arguments null, array{key1: bool|null, key2: null} and true will always evaluate to true.', + 51, + $tipText, + ], + ]); } public function testBug12412(): void diff --git a/tests/PHPStan/Rules/Comparison/data/bug-12755.php b/tests/PHPStan/Rules/Comparison/data/bug-12755.php index 6df2876e3b..99bd5faac5 100644 --- a/tests/PHPStan/Rules/Comparison/data/bug-12755.php +++ b/tests/PHPStan/Rules/Comparison/data/bug-12755.php @@ -2,6 +2,13 @@ namespace Bug12755; +class MyEnum +{ + public const ONE = 'one'; + public const TWO = 'two'; + public const THREE = 'three'; +} + class HelloWorld { /** @@ -32,4 +39,52 @@ public function testBool(array $myArray): ?\stdClass return (object) $myArray; } + + /** + * @param array{ + * key1: ?bool, + * key2: null, + * } $myArray + */ + public function testNull(array $myArray): ?\stdClass + { + if (\in_array(null, $myArray, true)) { + return null; + } + + return (object) $myArray; + } + + /** + * @param list $stack + */ + public function testEnum(array $stack): bool + { + return count($stack) === 1 && in_array(MyEnum::ONE, $stack, true); + } + + /** + * @param array{1|2|3} $stack + * @param array{1|2|3, 1|2|3} $stack2 + * @param array{1|2|3, 2|3} $stack3 + * @param array{a?: 1, b: 2|3} $stack4 + * @param array{a?: 1} $stack5 + */ + public function sayHello(array $stack, array $stack2, array $stack3, array $stack4, array $stack5): void + { + if (in_array(1, $stack, true)) { + } + + if (in_array(1, $stack2, true)) { + } + + if (in_array(1, $stack3, true)) { + } + + if (in_array(1, $stack4, true)) { + } + + if (in_array(1, $stack5, true)) { + } + } } From 4313decf97bda39b4e9d66718144521fcfe22efa Mon Sep 17 00:00:00 2001 From: sayuprc Date: Tue, 6 May 2025 22:53:35 +0900 Subject: [PATCH 4/4] Improvement to a better way --- src/Rules/Comparison/ImpossibleCheckTypeHelper.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Rules/Comparison/ImpossibleCheckTypeHelper.php b/src/Rules/Comparison/ImpossibleCheckTypeHelper.php index 4e30d9c2fb..0551a2b2d1 100644 --- a/src/Rules/Comparison/ImpossibleCheckTypeHelper.php +++ b/src/Rules/Comparison/ImpossibleCheckTypeHelper.php @@ -153,7 +153,7 @@ public function findSpecifiedType( foreach ($haystackArrayTypes as $haystackArrayType) { if ($haystackArrayType instanceof ConstantArrayType) { foreach ($haystackArrayType->getValueTypes() as $i => $haystackArrayValueType) { - if ($haystackArrayValueType instanceof UnionType || $haystackArrayType->isOptionalKey($i)) { + if (count($haystackArrayValueType->getFiniteTypes()) > 1 || $haystackArrayType->isOptionalKey($i)) { continue; }