Add false to return types of class_implements() #395
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The \class_implements() function may return an array or false when it fails Based on phpstan/phpstan#4172
Member
|
Could you also update class_parents and class_uses? |
Author
|
Done. Do I need to squash the commits or can you do that when accepting the PR? |
Member
|
Now handling in PHPStan itself needs to be fixed :) It's fine, I can squash it before merging. |
staabm
reviewed
Dec 2, 2020
| 'class_implements' => ['array<string,string>', 'what'=>'object|string', 'autoload='=>'bool'], | ||
| 'class_parents' => ['array<string,class-string>', 'instance'=>'object|string', 'autoload='=>'bool'], | ||
| 'class_uses' => ['array<string,string>', 'what'=>'object|string', 'autoload='=>'bool'], | ||
| 'class_implements' => ['array<string,string>|false', 'what'=>'object|string', 'autoload='=>'bool'], |
Contributor
There was a problem hiding this comment.
is a interface also a class-string which can be used instead of string ?
ondrejmirtes
force-pushed
the
master
branch
3 times, most recently
from
d45166a to
3526237
Compare
Member
|
Already done on master, but thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The \class_implements() function may return an array or false when it fails
Based on phpstan/phpstan#4172