Utilize array_last() #4504
Merged
Utilize array_last() #4504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please also add php84 polyfill to all the places. And once it's merged the bootstrap.php also needs to be modified in phpstan/phpstan. |
Member
|
The polyfills also need to be mentioned at the bottom of scoper.inc.php (that's what I screwed up last time and shipped it, lead to crashing in some projects). |
Collaborator
|
This pull request has been marked as ready for review. |
Contributor
Author
|
something is fishy with shipmonk/composer-dependency-analyser |
Member
|
Maybe needs to run on 8.5? |
Contributor
Author
|
seems this did the trick. thank you. |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more readable code by using
array_last. also adds symfony/polyfills required for release builds which support PHP older than 8.5fixes ~9x "offset might not exist" errors on phpstan-src with
reportPossiblyNonexistentGeneralArrayOffset: true