Resolve template with value of BackEnum #4548
Conversation
VincentLanglet
changed the title
|
This pull request has been marked as ready for review. |
|
interessting.. does it also solve phpstan/phpstan#13782 ? |
You don't appear on the issue bot https://github.com/phpstan/phpstan-src/actions/runs/19269104831?pr=4548 |
yes, thats because the issue does not yet have a label like "bug" or "feature request". |
src/Type/ValueOfType.php
Outdated
| if ($this->type->isEnum()->yes()) { | ||
| if ( | ||
| $this->type instanceof TemplateType | ||
| && $this->type->getBound()->equals(new ObjectType('BackedEnum')) |
There was a problem hiding this comment.
should this be the other way arround?
| && $this->type->getBound()->equals(new ObjectType('BackedEnum')) | |
| && new ObjectType('BackedEnum')->isSuperTypeOf($this->type->getBound())->yes()? |
There was a problem hiding this comment.
just had a look into the code-base. it seems we have spots where a Bound is compared using equals and sometimes it uses isSuperTypeOf.
I am not sure whether thats on purpose or an oversight
There was a problem hiding this comment.
isSuperTypeOf is better here indeed, in case someone use
interface SuperBackedEnum extends \BackedEnum
and a template of SuperBackedEnum.
test added
Oh ok. Test added and seems like it does close phpstan/phpstan#13782. |
3 participants
Closes phpstan/phpstan#12219
Closes phpstan/phpstan#13638
Closes phpstan/phpstan#13282
Closes phpstan/phpstan#13782