Add ArrayCountValuesDynamicReturnTypeExtension. #4615
Merged
+116
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mad-briller
force-pushed
the
array-count-values
branch
from
fc11ffa to
f247414
Compare
Collaborator
|
This pull request has been marked as ready for review. |
staabm
reviewed
Dec 4, 2025
Contributor
Author
|
shopware ci failure looks expected as they are calling |
Member
|
Thank you! |
Contributor
|
I think I found two bugs with the current implementation, I opened #4618 about it @ondrejmirtes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#13816
The issue states that stringable objects are accepted, but it turns out that this is not the case:
https://3v4l.org/07vKm#v8.4.15