Fix Access to an undefined static property #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes phpstan/phpstan#4734 |
|
Can you please access an undefined property in the test and assert the error message so that we're sure it just doesn't silence all errors? Thank you. |
Sure, I first need to fix the two failing tests... |
|
@ondrejmirtes inClosureBindClass are sometimes Any idea why ? Do you know any change in the behavior ? |
|
I have no idea... |
VincentLanglet
force-pushed
the
bug4734
branch
3 times, most recently
from
03b4ad9
to
96fc794
Compare
|
Fixed @ondrejmirtes :) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I found a solution