fix for big int-ranges

[voku]

fix issue #6375

[staabm]

Could you add a failing unit test?

[voku]

@staabm If I try to add a test like this ...

		$builder = ConstantArrayTypeBuilder::createFromConstantArray(
			new ConstantArrayType(
				[new ConstantIntegerType(0), new ConstantIntegerType(1)],
				[new StringType(), new StringType()],
			),
		);
		$builder->setOffsetValueType(IntegerRangeType::fromInterval(-2147483648, 2147483647), new StringType());

... I see I exception from phpunit itself:

The data provider specified for PHPStan\PhpDoc\TypeDescriptionTest::testParsingDesiredTypeDescription is invalid.
ValueError: The supplied range exceeds the maximum array size: start=-2147483648 end=2147483647

EDIT: test added and added a missing "-" before min-range self::ARRAY_COUNT_LIMIT :-P

[staabm]

I dont think the fix is correct.

It reads like a range from a value smaller then -256 would no longer be possible?

[voku]

It wasn't possible before anyway, see next lines of code ... if (count($scalarTypes) > 0 && count($scalarTypes) < self::ARRAY_COUNT_LIMIT) {...

[staabm]

I think its not the same thing to have a range of at max 256 elements vs only ranges between -256 and +256

[voku]

Other ideas? The problem is, we need to check this before the range( code, otherwise php will crash, Maybe we can avoid range and use a loop here?

[staabm]

Hmm max-min <= limit could work since stepping is always 1 in this cases?

[voku]

Yes, that was the idea. I already tried it, maybe you can take look at it, thanks.

[ondrejmirtes]

I don't understand the logic. The $scalarTypes array should never contain IntegerRangeType, why do you assign it there?

[voku]

I am sure that the classes that triggers the issue #6375 contains int-ranges and that the range call triggers the fatal error. So I tried to test it via unit tests.

What type triggers the fatal error from issue #6375? Does the int type somehow contains the int-range? I thought that this is a new type? 🤔

[ondrejmirtes]

I'm sorry, I didn't understand your fix, so I fixed it by myself: d3f968d