Fix trait detection recursion for anonymous classes

[herndlm]

Closes phpstan/phpstan#6442, aftermath of 11176c7.

This was a missing edge case that lead to endless recursion in case the trait looking for and anonymous class using it were in the same file. By not skipping the node, it would start looking at the anonymous class, find the trait usage, start looking for the trait, find it, come to the anonymous class, find the trait usage, start looking for the trait, ..

[ondrejmirtes]

Hi, I really need the test to be able to merge this. Can you push what you've tried to reproduce it?

[herndlm]

Oh I have a different behaviour now on my other machine. Sure, I'll check that out and push that then. Might take a bit.
UPDATE: there seems to be a second recursion problem. Thinking about splitting the PRs :/

[ondrejmirtes]

Also - please use the original source code (it has more classes):

trait T
{
    public function x(): void
	{
		\PHPStan\dumpType(parent::class);
	}
}

class A {}

class B extends A
{
	use T;
}

new class() extends B
{
	use T;
};

[herndlm]

Very odd, it started behaving the same strange way now too. Initially it was working (and showing another recursion problem), then I added and removed classes from the test file and now I always get reflection errors. It feels like some caching or so could be the culprit, but even after deleting all caches I can think of I have the same errors :/
Let's see what CI tells..
I get e.g.

Reflection error: Bug6442\T not found

when running via php vendor/bin/phpunit tests/PHPStan/Analyser/AnalyserIntegrationTest.php. Am I short-circuiting something there?

[herndlm]

Also - please use the original source code (it has more classes):

this was on purpose for now, as the PR here does not yet fix another recursion problem with parent:: in the trait :/

[ondrejmirtes]

So please fix all of the issues related to that bug report (otherwise it's not really a regression test for that bugreport and cannot be merged/closed). Thanks :)

[ondrejmirtes]

Your reflection error might be fixable by running "composer dump" whenever you move/add classes.

[herndlm]

Your reflection error might be fixable by running "composer dump" whenever you move/add classes.

that was really it! thx! I was not thinking that composer might be doing anything with those test files.
ok, I can now work on the full/clean fix :)

[herndlm]

well, looks like something is still/now broken on Windows

[ondrejmirtes]

$fileName === $originalClassFileName will be false probably because of different directory separators

Use FileHelper:normalizePath.

[herndlm]

maybe I should try to normalize it earlier / only once, give me a minute

[ondrejmirtes]

Thank you!

[herndlm]

Thank you too for the pointers 🎉