Closure::__invoke is not in PHP reflection

phpstan · Jan 22, 2017 · adf5a28 · adf5a28
1 parent 254def8
commit adf5a28
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 3 deletions.
diff --git a/src/Reflection/Php/PhpClassReflectionExtension.php b/src/Reflection/Php/PhpClassReflectionExtension.php
@@ -137,7 +137,20 @@ public function getMethod(ClassReflection $classReflection, string $methodName):
 	private function createMethods(ClassReflection $classReflection): array
 	{
 		$methods = [];
-		foreach ($classReflection->getNativeReflection()->getMethods() as $methodReflection) {
+		$reflectionMethods = $classReflection->getNativeReflection()->getMethods();
+		if ($classReflection->getName() === \Closure::class || $classReflection->isSubclassOf(\Closure::class)) {
+			$hasInvokeMethod = false;
+			foreach ($reflectionMethods as $reflectionMethod) {
+				if ($reflectionMethod->getName() === '__invoke') {
+					$hasInvokeMethod = true;
+					break;
+				}
+			}
+			if (!$hasInvokeMethod) {
+				$reflectionMethods[] = $classReflection->getNativeReflection()->getMethod('__invoke');
+			}
+		}
+		foreach ($reflectionMethods as $methodReflection) {
 			$declaringClass = $this->broker->getClass($methodReflection->getDeclaringClass()->getName());
 
 			$phpDocParameterTypes = [];

diff --git a/src/Reflection/Php/PhpMethodReflection.php b/src/Reflection/Php/PhpMethodReflection.php
@@ -189,6 +189,19 @@ public function getParameters(): array
 					true
 				);
 			}
+			if (
+				$this->declaringClass->getName() === 'Closure'
+				&& $this->reflection->getName() === '__invoke'
+				&& count($this->parameters) < 1
+			) {
+				$this->parameters[] = new DummyParameter(
+					'args',
+					new MixedType(),
+					true,
+					false,
+					true
+				);
+			}
 		}
 
 		return $this->parameters;
@@ -199,8 +212,16 @@ public function isVariadic(): bool
 		$isNativelyVariadic = $this->reflection->isVariadic();
 		if (
 			!$isNativelyVariadic
-			&& $this->declaringClass->getName() === 'ReflectionMethod'
-			&& $this->reflection->getName() === 'invoke'
+			&& (
+				(
+					$this->declaringClass->getName() === 'ReflectionMethod'
+					&& $this->reflection->getName() === 'invoke'
+				)
+				|| (
+					$this->declaringClass->getName() === 'Closure'
+					&& $this->reflection->getName() === '__invoke'
+				)
+			)
 		) {
 			return true;
 		}

diff --git a/tests/PHPStan/Rules/Methods/data/call-methods.php b/tests/PHPStan/Rules/Methods/data/call-methods.php
@@ -133,4 +133,9 @@ public function acceptsString(string $foo)
 function () {
 	$foo = new ClassWithToString();
 	$foo->acceptsString($foo);
+
+	$closure = function () {
+
+	};
+	$closure->__invoke(1, 2, 3);
 };