False positive: If condition is always false.

[iluuu1994]

https://phpstan.org/r/eae81481-04ee-44d2-8ee8-e573625aa034

class HelloWorld
{
	const CONFIG = [
		0 => ['foo' => false],
		1 => ['foo' => false],
	];
	
	public function sayHello(int $key): void
	{
		$config = self::CONFIG[$key]['foo'] ?? true;
		
		if ($config) {
			print 'Foo';
		}
	}
}

If condition is always false.

This only happens when the CONFIG is multidimensional. This here works:

https://phpstan.org/r/0d649821-d7b9-446b-99a5-acd0e3a66002

[julienfalque]

Maybe related:

<?php

$foo = true;

if (mt_rand(0, 1) === 1) {
    $foo = false;

    if (mt_rand(0, 1) === 1) {
        $foo = true;
    }
}

if ($foo) {
}

PhpStan reports if condition is always true: https://phpstan.org/r/d61749a7-76e5-480a-8057-cd8a1c258523

[phpstan-bot]

@julienfalque After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-13: If condition is always true.
+No errors

[ondrejmirtes]

@julienfalque Your issue got fixed by phpstan/phpstan-src@d4edc59 but was unrelated to the OP issue.

[julienfalque]

Thank you @ondrejmirtes.

[staabm]

@ondrejmirtes this bug is listed in the phpstan 1.0 release notes as beeing fixed. it seems thats a typo/mistake?

[ondrejmirtes]

@staabm Not really, it fixed #2420 (comment). (This is why I insist on separate issues for unrelated problems, but I didn't do that a lot 1,5 year ago).

[phpstan-bot]

@iluuu1994 After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-14: If condition is always false.
+No errors

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.