Result of && is always false.

[aivchen]

Bug report

PHPStan shouldn't report any errors in this case because it can't predict what rand() returns.

Code snippet that reproduces the problem

https://phpstan.org/r/e7652aad-b990-4aa7-8b6e-eeed31adc036

Expected output

No errors.

[ondrejmirtes]

Hi,
the problem is the in_array part: https://phpstan.org/r/7676c51e-adc9-4b12-b72f-866417d256cf

PHPStan correctly knows that in_array will return true, !in_array will return false, so the right part of the && condition will not even get executed.

If you have a more precise code sample with your problem, please post it.

[ondrejmirtes]

Oh, I get it, in the first iteration, the array is empty. So PHPStan should not complain. Thanks.

[davidkudera]

Hi, I'm getting the same error for this code: https://phpstan.org/r/f90376e0-9612-4994-b515-0725a248e756

[ondrejmirtes]

@davidkudera In your case PHPStan is right. At no point is $a value changed, so it's always true.

[davidkudera]

@ondrejmirtes Yeah, but at the first iteration $b is false. It resolves to true only for the next iterations.

[aivchen]

@davidkudera PHPStan reports Left side of && is always true. It wants to say you that using $a variable in your loop is useless.

[ondrejmirtes]

You can simplify the code without changing how it behaves: https://phpstan.org/r/aea94433-f31e-4d97-a668-25689ecb69d5

[davidkudera]

Oh, sorry, I should probably ask for new glasses... My problem is with "right" side of &&, this issue is about "result" and my simplified example is about "left" side.

I tried to simplify my actual code a bit less for the playground, but I'm unable to reproduce my error (Right side of && is always false) there. Also, the same file (copy-paste) shows no error in another project.

[ondrejmirtes]

Isn't it about the treatPhpDocTypesAsCertain settings?

[davidkudera]

You're right. I have that error only when I set it to false. Here is how the code basically looks like https://phpstan.org/r/d5cad7f0-6501-4ea8-bc80-08e7d6ea2c29 (still works fine on the playground).

I'll remove that option from my config. Thank you

[ondrejmirtes]

You should really reproduce it in the playground, I need it for a regression test case. I know about this problem, but I need more data.

[davidkudera]

Here you go: https://phpstan.org/r/bb5d6c90-4df9-4174-b16d-caee1296f944

I had to start from my minimal example and add more and more code. The last line I added was the culprit (the method call on line 23).

The workaround is also interesting - just flip lines 22 and 23 and it will work without any errors.

[ondrejmirtes]

Perfect! This helps me tremendously!