Reflection error on class_alias object definition after upgraded from 0.12.4 to 0.12.9

[shulard]

Support question

Hello,

I'm using the hoa/websocket package which rely to class_alias to simplify some class names...

For example the class Hoa\Socket\Connection\Connection is aliased to Hoa\Socket\Connection.

You can check the definition here: https://github.com/hoaproject/Socket/blob/master/Source/Connection/Connection.php#L813

After updating to phpstan 0.12.9, I got an error :

Reflection error: Hoa\Socket\Connection not found.

Before the update, the analysis hasn't any trouble with the @param and @var aliased class names.

I saw that there is a new typeAliases in the configuration but it doesn't seems to fix my issue. Here is my local phpstan.neon configuration :

includes:
	- vendor/jangregor/phpstan-prophecy/src/extension.neon
parameters:
    level: max
    inferPrivatePropertyTypeFromConstructor: true
    paths:
        - public
        - src
        - tests
    typeAliases:
        Hoa\Socket\Connection: 'Hoa\Socket\Connection\Connection'
        Hoa\Stream: 'Hoa\Stream\Stream'

Do you know how to understand this issue and fix it ?

[ondrejmirtes]

Type aliases will not help you here, that's not what they are meant for.

Can you please post some minimal code using Hoa library that it will crash on? So that I can have a regression test.

[shulard]

Yep I can create such code. Do you want that I make a PR somewhere or I just add the code here in a comment ?

[ondrejmirtes]

Just here, and as minimal as possible. I think something very close to new Server(...) will suffice. Thanks.

[ondrejmirtes]

I think I fixed it, please try the latest dev-master of phpstan/phpstan (phpstan/phpstan-src@c0cb3a6, 0749384). Thank you.

[ondrejmirtes]

It's possible you'll have to add a line like this to your PHPStan's bootstrap (https://github.com/phpstan/phpstan#bootstrap-file - see README):

class_exists(\Hoa\Stream::class);

All of this is just because Hoa's aliases aren't friendly to static analysis, I reported this a few days ago: hoaproject/Consistency#34

[shulard]

Hello !

It seems to work on the dev-master version with a bootstrap file ! Thank you for the fix, I know that Hoa has a strange alias behaviour (hidden inside a function)... I'll try to help moving forward those new packages version to allow removing this specific code !

Thank you for your help 😉.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.