Generics restricted to array types are reporting errors

[stof]

Bug report

I'd like to use a generic class, where the generic type is always an array of scalars, but the exact shape can be configured when using it. The typechecker already handles this fine for code using the class, but it reports errors in the class definition, for the @template annotation and for the @param annotation.

Code snippet that reproduces the problem

https://phpstan.org/r/e5cb3813-71b9-42b2-8e66-bcb65c8d2bcd

Expected output

Only the error at line 25 should be reported.

[phpstan-bot]

@stof After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
  4: PHPDoc tag @template T for class HelloWorld with bound type array<bool|float|int|string|null> is not supported.
  9: Method HelloWorld::sayHello() has parameter $d with no value type specified in iterable type array.
- 9: PHPDoc tag @param for parameter $d with type T is not subtype of native type array.
-25: Parameter #1 $d of method HelloWorld<array<string, bool|string>>::sayHello() expects array('a' => string, 'b' => bool), array('a' => string, 'b' => DateTime) given.
+ 9: PHPDoc tag @param for parameter $d with type T is not subtype of native type array.

Full report

Line	Error
4	`PHPDoc tag @template T for class HelloWorld with bound type array<bool
9	Method HelloWorld::sayHello() has parameter $d with no value type specified in iterable type array.
9	PHPDoc tag @param for parameter $d with type T is not subtype of native type array.

[stof]

This now kept only the errors I considered false positives, removing the one I considered OK...

[phpstan-bot]

@stof After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
- 4: PHPDoc tag @template T for class HelloWorld with bound type array<bool|float|int|string|null> is not supported.
- 9: Method HelloWorld::sayHello() has parameter $d with no value type specified in iterable type array.
- 9: PHPDoc tag @param for parameter $d with type T is not subtype of native type array.
+ 4: PHPDoc tag @template T for class HelloWorld with bound type null is not supported.
 25: Parameter #1 $d of method HelloWorld<array<string, bool|string>>::sayHello() expects array('a' => string, 'b' => bool), array('a' => string, 'b' => DateTime) given.

Full report

Line	Error
4	PHPDoc tag @template T for class HelloWorld with bound type null is not supported.
25	`Parameter #1 $d of method HelloWorld<array<string, bool

[stof]

@ondrejmirtes any reason to forbid null for the bound types when using a union type in the array bound type ?

[ondrejmirtes]

@stof No reason, just that someone needs to step up and implement TemplateNullType similar to this commit: phpstan/phpstan-src@4e7d6c1

I believe it's really straightforward.

[phpstan-bot]

@stof After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
- 4: PHPDoc tag @template T for class HelloWorld with bound type array<bool|float|int|string|null> is not supported.
- 9: Method HelloWorld::sayHello() has parameter $d with no value type specified in iterable type array.
- 9: PHPDoc tag @param for parameter $d with type T is not subtype of native type array.
-25: Parameter #1 $d of method HelloWorld<array<string, bool|string>>::sayHello() expects array('a' => string, 'b' => bool), array('a' => string, 'b' => DateTime) given.
+ 4: PHPDoc tag @template T for class HelloWorld with bound type null is not supported.
+25: Parameter #1 $d of method HelloWorld<array<string, bool|string>>::sayHello() expects array{a: string, b: bool}, array{a: string, b: DateTime} given.

Full report

Line	Error
4	PHPDoc tag @template T for class HelloWorld with bound type null is not supported.
25	`Parameter #1 $d of method HelloWorld<array<string, bool

[ondrejmirtes]

Solved the nullable union bound: phpstan/phpstan-src@1d8b2eb

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.