in_array with possible missing values throws "will always evaluate to true" in strict mode

[faizanakram99]

Bug report

This code snip will not always be true as OrderSaved::$dtos might not contain ReceiptOrder since ReceiptOrder::fromOrder() can return null

if (\in_array(ReceiptOrder::class, $missingClasses, true)) {
}

Code snippet that reproduces the problem

https://phpstan.org/r/7b6a301e-f874-4dce-bcd5-1c54cd42e854

Expected output

No errors

[phpstan-bot]

@faizanakram99 After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
 PHP 7.4 – 8.0 (1 error)
 ==========
 
-63: Call to function in_array() with arguments 'ReceiptOrder', array<0|1, 'PickingOrder'|'ReceiptOrder'> and true will always evaluate to true.
+-1: Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40
+Run PHPStan with --debug option and post the stack trace to:
+https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md
 
 PHP 7.1 – 7.3 (3 errors)
 ==========

Full report

PHP 7.4 – 8.0 (1 error)

Line

Error

-1

Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40Run PHPStan with --debug option and post the stack trace to:https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

PHP 7.1 – 7.3 (3 errors)

Line	Error
60	Syntax error, unexpected ',' on line 60
60	Syntax error, unexpected T_DOUBLE_ARROW on line 60
60	Syntax error, unexpected T_STRING, expecting T_PAAMAYIM_NEKUDOTAYIM on line 60

[phpstan-bot]

@faizanakram99 After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
 PHP 7.1 – 7.3 (3 errors)
 ==========
 
-60: Syntax error, unexpected ',' on line 60
+60: Syntax error, unexpected T_STRING, expecting T_PAAMAYIM_NEKUDOTAYIM on line 60
 60: Syntax error, unexpected T_DOUBLE_ARROW on line 60
-60: Syntax error, unexpected T_STRING, expecting T_PAAMAYIM_NEKUDOTAYIM on line 60
+60: Syntax error, unexpected ',' on line 60

Full report

PHP 7.4 – 8.0 (1 error)

Line	Error
63	`Call to function in_array() with arguments 'ReceiptOrder', array<0

PHP 7.1 – 7.3 (3 errors)

Line	Error
60	Syntax error, unexpected T_STRING, expecting T_PAAMAYIM_NEKUDOTAYIM on line 60
60	Syntax error, unexpected T_DOUBLE_ARROW on line 60
60	Syntax error, unexpected ',' on line 60

[phpstan-bot]

@faizanakram99 After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-PHP 7.4 – 8.0 (1 error)
+PHP 7.4 – 8.0
 ==========
 
-63: Call to function in_array() with arguments 'ReceiptOrder', array<0|1, 'PickingOrder'|'ReceiptOrder'> and true will always evaluate to true.
+No errors
 
 PHP 7.1 – 7.3 (3 errors)
 ==========

Full report

PHP 7.4 – 8.0

No errors

PHP 7.1 – 7.3 (3 errors)

Line	Error
60	Syntax error, unexpected ',' on line 60
60	Syntax error, unexpected T_DOUBLE_ARROW on line 60
60	Syntax error, unexpected T_STRING, expecting T_PAAMAYIM_NEKUDOTAYIM on line 60

[ondrejmirtes]

Fixed: phpstan/phpstan-src@4321374

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.