phpstan assumes _SESSION always exists

[staabm]

Bug report

Code snippet that reproduces the problem

I dont expect the error we get at https://phpstan.org/r/34e05837-1aa9-41f2-8a74-0d3b30f7f54d
since the super global $_SESSION is only defined after session_start() is called

see https://3v4l.org/0a8Ie vs. https://3v4l.org/GlBZ2

Expected output

no error

[ondrejmirtes]

This fix is probably wrong. phpstan/phpstan-src#321

[sjerdo]

For some reason the inverse does not trigger any error: https://phpstan.org/r/65dbfe18-b20e-4655-a280-935f5089d1f3

[phpstan-bot]

@staabm After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-10: Unreachable statement - code above always terminates.
+ 5: Method HelloWorld::sayHello() should return bool but return statement is missing.

Full report

Line	Error
5	Method HelloWorld::sayHello() should return bool but return statement is missing.

[phpstan-bot]

@sjerdo After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-No errors
+5: Method HelloWorld::sayHello() should return bool but return statement is missing.

Full report

Line	Error
5	Method HelloWorld::sayHello() should return bool but return statement is missing.

[phpstan-bot]

@staabm After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-10: Unreachable statement - code above always terminates.
+No errors

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.