Template type not supporting string|null although it works fine

[janedbal]

Bug report

Getting PHPDoc tag @template T for method HelloWorld::normalize() with bound type null is not supported. in following snippet, but the functionality seems working, is that just invalid error?

Code snippet that reproduces the problem

https://phpstan.org/r/04528bd4-6738-4b6e-b9f3-4756ce08c3f7

Expected output

No error on line 19

[phpstan-bot]

@janedbal After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
- 7: Parameter #1 $foo of method HelloWorld::strict() expects string, null given.
-19: PHPDoc tag @template T for method HelloWorld::normalize() with bound type null is not supported.
+-1: Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40
+Run PHPStan with --debug option and post the stack trace to:
+https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

Full report

Line

Error

-1

Internal error: PHPStan\Rules\Methods\WrongCaseOfInheritedMethodRule::findMethod(): Argument #2 ($classReflection) must be of type PHPStan\Reflection\ClassReflection, null given, called in /var/task/vendor/phpstan/phpstan-strict-rules/src/Rules/Methods/WrongCaseOfInheritedMethodRule.php on line 40Run PHPStan with --debug option and post the stack trace to:https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md

[phpstan-bot]

@janedbal After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
- 7: Parameter #1 $foo of method HelloWorld::strict() expects string, null given.
+19: Method HelloWorld::normalize() should return T of string|null but return statement is missing.
 19: PHPDoc tag @template T for method HelloWorld::normalize() with bound type null is not supported.

Full report

Line	Error
19	`Method HelloWorld::normalize() should return T of string
19	PHPDoc tag @template T for method HelloWorld::normalize() with bound type null is not supported.

[phpstan-bot]

@janedbal After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
- 7: Parameter #1 $foo of method HelloWorld::strict() expects string, null given.
-19: PHPDoc tag @template T for method HelloWorld::normalize() with bound type null is not supported.
+ 7: Parameter #1 $foo of method HelloWorld::strict() expects string, null given.

Full report

Line	Error
7	Parameter #1 $foo of method HelloWorld::strict() expects string, null given.

[ondrejmirtes]

Fixed: phpstan/phpstan-src@1d8b2eb

[ZebulanStanphill]

@ondrejmirtes Is it? It looks like passing null to the method is still considered invalid.

[ondrejmirtes]

$this->normalize(null) resolves to null which looks correct to me.

[ZebulanStanphill]

@ondrejmirtes Oh, you're right. I misread the code snippet. 👍

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.