Falsy Type after for condition

[staabm]

Feature request

Analog to the fix in https://github.com/phpstan/phpstan-src/blob/3166ba31a8768979a40e55f1bbfea9ba4449a3d8/tests/PHPStan/Analyser/data/bug-5322.php

i would expect this to apply to for-loops
https://phpstan.org/r/896b762d-0edd-4775-8057-ad47fcbfd5ec

(The example is a bit theoretical though)

[ondrejmirtes]

Hi, please contribute the fix by yourself, that commit has everything you need. It might also apply to do-while loop too.

Also please understand that when majority of new feature requests come from a single person, I have to internally rate limit implementing those feature requests myself so I can serve the whole userbase equally. Thanks for understanding.

[staabm]

Thats totally fine. Just want to get in contact first to get your opinion on the case.

It might also apply to do-while loop too.

I checked this case already and came to the conclusion, that it works fine

[ondrejmirtes]

Yeah, I was excited about the while loop report, it was an obvious hole 😊

[phpstan-bot]

@staabm After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-15: Method Bug5322\Foo::doBar() has no return typehint specified.
+15: Method Bug5322\Foo::doBar() has no return type specified.
 22: Expected type int, actual: int|null

Full report

Line	Error
15	Method Bug5322\Foo::doBar() has no return type specified.
22	`Expected type int, actual: int

[ondrejmirtes]

I think PHPStan got it right, it can be int|null. Feel free to open a new issue if you find a for-loop related bug :)

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.